Repository navigation
Conversation
LegendHDF5IO 0.2 registers the LH5 datatype names of custom types with `register_datatype!` instead of writing into its datatype dictionary and extending `datatype_to_string`. The extension registers CartesianPoint and CylindricalPoint that way when the function exists and keeps the old route for LegendHDF5IO 0.1, so both versions work. The IO, CSG IO and Geant4 tests pass with LegendHDF5IO 0.1.19 and 0.2.0. Assisted-By: generative AI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude (Anthropic) in Claude Code, a Fable 5.1 session at xhigh effort, under the guidance of @oschulz, who asked for this draft. Opened as a draft until LegendHDF5IO 0.2.0 is in the LEGEND registry.
LegendHDF5IO 0.2 registers the LH5 datatype names of custom types with
register_datatype!instead of writing into its datatype dictionary and extendingdatatype_to_string. The extension now registersCartesianPointandCylindricalPointthat way when the function exists and keeps the old route for LegendHDF5IO 0.1, so both versions work without a compat change inProject.toml. The test environment allows LegendHDF5IO 0.1 and 0.2.Verified: the IO, CSG IO and Geant4 test groups pass with LegendHDF5IO 0.1.19 and with 0.2.0.